refactor(semantic)!: remove SymbolFlags::Export
#7414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2024
Merged
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Dunqing
changed the title
SymbolFlags::Export
Dunqing
changed the title
SymbolFlags::ExportSymbolFlags::Export
github-actions
bot
added
A-semantic
CodSpeed Performance ReportMerging #7414 will not alter performanceComparing Summary
|
Merge activity
|
close: #7338 close: #7344 The `SymbolFlags::Export` is Initially used to solve `ExportSpecifier` that is not `IdentifierReference` that causes we cannot determine whether a Binding is not used everywhere by `Semantic`. Since #3820 this problem is solved, so we don't need `SymbolFlags::Export` no longer. Also, removing this can help us easier to pass the `Semantic` check in `Transformer`
Boshen
force-pushed
the
11-22-refactor_linter_only-used-in-recursion_improve_implementation_to_remove_using_symbolflags_export
branch
from
32228c2 to
c90537f
Compare
Boshen
force-pushed
the
11-22-refactor_semantic_remove_symbolflags_export
branch
from
338571d to
27b2268
Compare
Base automatically changed from
11-22-refactor_linter_only-used-in-recursion_improve_implementation_to_remove_using_symbolflags_export
to
main
November 22, 2024 09:27
graphite-app
bot
deleted the
11-22-refactor_semantic_remove_symbolflags_export
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #7338
close: #7344
The
SymbolFlags::Exportis Initially used to solveExportSpecifierthat is notIdentifierReferencethat causes we cannot determine whether a Binding is not used everywhere bySemantic.Since #3820 this problem is solved, so we don't need
SymbolFlags::Exportno longer. Also, removing this can help us easier to pass theSemanticcheck inTransformer