Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/logic-assignment): shorten code #7419

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 22, 2024

Use create_spanned_read_expression instead of create_spanned_expression, as it's shorter than specifying ReferenceFlags manually.

Copy link

graphite-app bot commented Nov 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 22, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 22, 2024 11:38
@overlookmotel
Copy link
Contributor Author

Trivial change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 22, 2024
Copy link
Contributor Author

overlookmotel commented Nov 22, 2024

Merge activity

  • Nov 22, 6:39 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 22, 6:42 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 22, 6:46 AM EST: A user merged this pull request with the Graphite merge queue.

Use `create_spanned_read_expression` instead of `create_spanned_expression`, as it's shorter than specifying `ReferenceFlags` manually.
@overlookmotel overlookmotel force-pushed the 11-22-refactor_transformer_logic-assignment_shorten_code branch from 89bdb35 to eb39a50 Compare November 22, 2024 11:42
@graphite-app graphite-app bot merged commit eb39a50 into main Nov 22, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 11-22-refactor_transformer_logic-assignment_shorten_code branch November 22, 2024 11:46
Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #7419 will not alter performance

Comparing 11-22-refactor_transformer_logic-assignment_shorten_code (eb39a50) with main (be5f843)

Summary

✅ 30 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant