Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer/async-generator-functions): correct all binding scope id #7425

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 22, 2024

Fixed a bunch of semantic errors by removing moving binding logic 😢. This plugin constructs a complex for-await replacement so that I wrongly move to an incorrect scope.

Copy link

graphite-app bot commented Nov 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Nov 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Nov 22, 2024
@Dunqing Dunqing changed the title feat(transformer/async-generator-functions): correct all binding scope id fix(transformer/async-generator-functions): correct all binding scope id Nov 22, 2024
@github-actions github-actions bot added the C-bug Category - Bug label Nov 22, 2024
Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #7425 will create unknown performance changes

Comparing 11-22-feat_transformer_async-generator-functions_correct_all_binding_scope_id (4d6bd07) with main (bb2c0c2)

Summary

🆕 30 new benchmarks

Benchmarks breakdown

Benchmark main 11-22-feat_transformer_async-generator-functions_correct_all_binding_scope_id Change
🆕 codegen[checker.ts] N/A 24.6 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 77.4 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 397.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 24.1 µs N/A
🆕 lexer[antd.js] N/A 22.3 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.3 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.5 ms N/A
🆕 linter[cal.com.tsx] N/A 1.1 s N/A
🆕 linter[checker.ts] N/A 2.6 s N/A
🆕 minifier[antd.js] N/A 437.2 ms N/A
🆕 minifier[react.development.js] N/A 2.9 ms N/A
🆕 minifier[typescript.js] N/A 545.3 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 78 µs N/A
🆕 parser[antd.js] N/A 106.6 ms N/A
🆕 parser[cal.com.tsx] N/A 24.6 ms N/A
🆕 parser[checker.ts] N/A 53.5 ms N/A
🆕 parser[pdf.mjs] N/A 17.4 ms N/A
🆕 semantic[RadixUIAdoptionSection.jsx] N/A 98.8 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 22, 2024
Copy link
Member

Boshen commented Nov 22, 2024

Merge activity

  • Nov 22, 11:24 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 22, 11:24 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 22, 11:37 AM EST: A user merged this pull request with the Graphite merge queue.

… id (#7425)

Fixed a bunch of semantic errors by removing moving binding logic 😢. This plugin constructs a complex `for-await` replacement so that I wrongly move to an incorrect scope.
@Boshen Boshen force-pushed the 11-22-feat_transformer_async-generator-functions_correct_all_binding_scope_id branch from 3179e8d to 4d6bd07 Compare November 22, 2024 16:29
@graphite-app graphite-app bot merged commit 4d6bd07 into main Nov 22, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-22-feat_transformer_async-generator-functions_correct_all_binding_scope_id branch November 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants