Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_tools): remove tsify helper attr from Ast derive macro #7435

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 23, 2024

We no longer use this attr.

Copy link

graphite-app bot commented Nov 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

overlookmotel commented Nov 23, 2024

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 23, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 23, 2024 14:02
@overlookmotel
Copy link
Contributor Author

Trivial change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 23, 2024
Copy link
Contributor Author

overlookmotel commented Nov 23, 2024

Merge activity

  • Nov 23, 9:03 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 23, 9:08 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 23, 9:13 AM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 11-23-refactor_ast_tools_remove_tsify_helper_attr_from_ast_derive_macro branch from df17e69 to cf0b3bc Compare November 23, 2024 14:09
@graphite-app graphite-app bot merged commit cf0b3bc into main Nov 23, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-23-refactor_ast_tools_remove_tsify_helper_attr_from_ast_derive_macro branch November 23, 2024 14:13
Copy link

codspeed-hq bot commented Nov 23, 2024

CodSpeed Performance Report

Merging #7435 will not alter performance

Comparing 11-23-refactor_ast_tools_remove_tsify_helper_attr_from_ast_derive_macro (cf0b3bc) with main (21614f2)

Summary

✅ 30 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant