feat(oxc_transformer): use better diagnostic message for ReplaceGlobalDefinesPlugin
#7439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #7439 will not alter performanceComparing Summary
|
shulaoda
deleted the
feat/replace-global-defines-better-diagnostic-message
branch
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Nov 24, 2024
### Description Related PR oxc-project/oxc#7439 I'm not sure if it's worth adding a `EventKind::InvalidDefineConfig` for `ReplaceGlobalDefinesConfig`. https://github.com/rolldown/rolldown/blob/52e0d11c4e3b655f4d6e76226b2e70086d41de44/crates/rolldown/src/module_loader/module_loader.rs#L89-L96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was handling plugin-related diagnostics in
rolldown, I encountered this issue.If there is a define key like
a.6.b, the error message states that`a.6.b` is not an identifier. However, it should actually be that`6` is not an identifier.