Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oxc_transformer): replace_global_define destructuring assignment optimization #7449

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Nov 24, 2024

Copy link

graphite-app bot commented Nov 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 24, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 11-24-feat_replace_global_define_destruct branch from 0ec3330 to 21140ac Compare November 24, 2024 09:55
Copy link

codspeed-hq bot commented Nov 24, 2024

CodSpeed Performance Report

Merging #7449 will not alter performance

Comparing 11-24-feat_replace_global_define_destruct (85ffed8) with main (d5df615)

Summary

✅ 30 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY force-pushed the 11-24-feat_replace_global_define_destruct branch from 21140ac to 42074a6 Compare November 24, 2024 10:17
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review November 24, 2024 10:17
@IWANABETHATGUY IWANABETHATGUY force-pushed the 11-24-feat_replace_global_define_destruct branch from 42074a6 to c5a6ac7 Compare November 24, 2024 10:17
@IWANABETHATGUY IWANABETHATGUY force-pushed the 11-24-feat_replace_global_define_destruct branch from c5a6ac7 to 85ffed8 Compare November 24, 2024 10:21
@IWANABETHATGUY IWANABETHATGUY changed the title feat: replace_global_define destruct feat(oxc_transformer): replace_global_define destruct Nov 24, 2024
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 24, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title feat(oxc_transformer): replace_global_define destruct feat(oxc_transformer): replace_global_define destructuring assignment optimization Nov 24, 2024
@Boshen Boshen merged commit 8797849 into main Nov 24, 2024
30 checks passed
@Boshen Boshen deleted the 11-24-feat_replace_global_define_destruct branch November 24, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transformer: replace global defines restructuring
3 participants