Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/class-properties): rename class_binding #7533

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 28, 2024

Pure refactor. Just rename a variable. class_binding is preferable, since this binding isn't always for the class name.

Copy link

graphite-app bot commented Nov 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 28, 2024
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #7533 will not alter performance

Comparing 11-28-refactor_transformer_class-properties_rename_class_binding_ (ab1214d) with main (71b3437)

Summary

✅ 30 untouched benchmarks

Copy link

graphite-app bot commented Dec 3, 2024

Merge activity

Pure refactor. Just rename a variable. `class_binding` is preferable, since this binding isn't always for the class *name*.
@Dunqing Dunqing force-pushed the 11-28-refactor_transformer_class-properties_rename_class_binding_ branch from f7d1be8 to ab1214d Compare December 3, 2024 07:46
@graphite-app graphite-app bot merged commit ab1214d into main Dec 3, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 11-28-refactor_transformer_class-properties_rename_class_binding_ branch December 3, 2024 07:52
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant