Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(minifier): temporary remove try_fold_if_block_one and try_fold_if_one_child #7536

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Nov 29, 2024

They are not idempotent.

Copy link

graphite-app bot commented Nov 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 29, 2024
Copy link
Member Author

Boshen commented Nov 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 29, 2024
Copy link
Member Author

Boshen commented Nov 29, 2024

Merge activity

  • Nov 29, 12:00 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 29, 12:04 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 29, 12:10 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 11-29-chore_minifier_temporary_remove_try_fold_if_block_one_and_try_fold_if_one_child_ branch from d5303ed to 62a8c5e Compare November 29, 2024 05:05
@graphite-app graphite-app bot merged commit 62a8c5e into main Nov 29, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-29-chore_minifier_temporary_remove_try_fold_if_block_one_and_try_fold_if_one_child_ branch November 29, 2024 05:10
Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #7536 will not alter performance

Comparing 11-29-chore_minifier_temporary_remove_try_fold_if_block_one_and_try_fold_if_one_child_ (62a8c5e) with main (d942a8d)

Summary

✅ 30 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant