Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oxc_transformer): support jsx pragma that are long member expressions #7538

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Nov 29, 2024

Copy link

graphite-app bot commented Nov 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

IWANABETHATGUY commented Nov 29, 2024

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 29, 2024
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review November 29, 2024 07:51
@IWANABETHATGUY IWANABETHATGUY changed the title fix: support arbitrary length member expr fix(oxc_transformer): support arbitrary length member expr Nov 29, 2024
@github-actions github-actions bot added the C-bug Category - Bug label Nov 29, 2024
Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #7538 will not alter performance

Comparing 11-29-fix_support_arbitrary_length_member_expr (a784a82) with main (f0e7acc)

Summary

✅ 30 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY changed the title fix(oxc_transformer): support arbitrary length member expr fix(oxc_transformer): support arbitrary length member expr jsx pragma Nov 29, 2024
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a minimal example? I'm not sure what we are changing here and what we are testing against.

Test can be added to tasks/transform_conformance/tests/babel-plugin-transform-react-jsx/test/fixtures

@IWANABETHATGUY
Copy link
Contributor Author

Can you provide a minimal example? I'm not sure what we are changing here and what we are testing against.

Test can be added to tasks/transform_conformance/tests/babel-plugin-transform-react-jsx/test/fixtures

TLDR,
before we could only support pragma like a.b (length could only be two if it is memberExpr), or a a identifier.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 11-29-fix_support_arbitrary_length_member_expr branch from 6f9a5c8 to c650d33 Compare November 29, 2024 08:56
@Boshen Boshen changed the title fix(oxc_transformer): support arbitrary length member expr jsx pragma feat(transformer): support jsx pragma that are long member expressions Nov 29, 2024
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 29, 2024
@IWANABETHATGUY IWANABETHATGUY removed C-bug Category - Bug C-enhancement Category - New feature or request labels Nov 29, 2024
@Boshen
Copy link
Member

Boshen commented Nov 29, 2024

I'll let the code owners to review.

@IWANABETHATGUY IWANABETHATGUY added the C-enhancement Category - New feature or request label Nov 29, 2024
@IWANABETHATGUY IWANABETHATGUY force-pushed the 11-29-fix_support_arbitrary_length_member_expr branch 2 times, most recently from aafc85d to 348f40f Compare November 29, 2024 17:03
@IWANABETHATGUY IWANABETHATGUY changed the title feat(transformer): support jsx pragma that are long member expressions feat(oxc_transformer): support jsx pragma that are long member expressions Nov 29, 2024
Copy link
Contributor Author

any feedback would be good, this pr intent to fix jsx.factory issue in rolldown

@overlookmotel
Copy link
Contributor

It's unfortunate that we have to allocate a Vec for the default, but I guess no easy way around that.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 2, 2024
Copy link
Contributor

overlookmotel commented Dec 2, 2024

Merge activity

  • Dec 2, 9:01 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 2, 9:01 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 2, 9:07 AM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 11-29-fix_support_arbitrary_length_member_expr branch from 13be032 to a784a82 Compare December 2, 2024 14:02
@graphite-app graphite-app bot merged commit a784a82 into main Dec 2, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-29-fix_support_arbitrary_length_member_expr branch December 2, 2024 14:07
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants