-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oxc_transformer): support jsx pragma that are long member expressions #7538
feat(oxc_transformer): support jsx pragma that are long member expressions #7538
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #7538 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a minimal example? I'm not sure what we are changing here and what we are testing against.
Test can be added to tasks/transform_conformance/tests/babel-plugin-transform-react-jsx/test/fixtures
TLDR, |
6f9a5c8
to
c650d33
Compare
...abel-plugin-transform-react-jsx/test/fixtures/misc/arbitrary_length_member_expr/options.json
Show resolved
Hide resolved
I'll let the code owners to review. |
aafc85d
to
348f40f
Compare
any feedback would be good, this pr intent to fix |
348f40f
to
13be032
Compare
It's unfortunate that we have to allocate a |
Merge activity
|
13be032
to
a784a82
Compare
related tests:
https://github.com/evanw/esbuild/blob/d34e79e2a998c21bb71d57b92b0017ca11756912/internal/bundler_tests/bundler_default_test.go#L6188-L6236