Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): use PropName trait from oxc_ecmascript #7543

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Nov 29, 2024

No description provided.

Copy link

graphite-app bot commented Nov 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Nov 29, 2024

@github-actions github-actions bot added the A-parser Area - Parser label Nov 29, 2024
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 29, 2024
Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #7543 will not alter performance

Comparing 11-29-refactor_parser_use_propname_trait_from_oxc_ecmascript_ (b24beeb) with main (63a66cf)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 29, 2024
Copy link
Member Author

Boshen commented Nov 29, 2024

Merge activity

  • Nov 29, 4:18 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 29, 4:18 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 29, 4:28 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 11-29-test_ecmascript_move_tests_to_oxc_minifier_due_to_cyclic_dependency_with_oxc_parser_ branch from 5920f7f to 9d6e14b Compare November 29, 2024 09:18
@Boshen Boshen force-pushed the 11-29-refactor_parser_use_propname_trait_from_oxc_ecmascript_ branch from 11e05b3 to b24beeb Compare November 29, 2024 09:19
Base automatically changed from 11-29-test_ecmascript_move_tests_to_oxc_minifier_due_to_cyclic_dependency_with_oxc_parser_ to main November 29, 2024 09:23
@graphite-app graphite-app bot merged commit b24beeb into main Nov 29, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 11-29-refactor_parser_use_propname_trait_from_oxc_ecmascript_ branch November 29, 2024 09:28
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant