Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(semantic)!: remove ModuleRecord from Semantic #7548

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Nov 29, 2024

ModuleRecord will eventually be moved to be linter specific thing for cross module data sharing, which means we can add more data to it.

@Boshen Boshen requested a review from Dunqing as a code owner November 29, 2024 16:25
Copy link

graphite-app bot commented Nov 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Nov 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 29, 2024
@Boshen Boshen changed the title refactor(semantic): remove ModuleRecord from Semantic refactor(semantic)!: remove ModuleRecord from Semantic Nov 29, 2024
`ModuleRecord` will eventually be moved to be linter specific thing for cross module data sharing, which means we can add more data to it.
@Boshen Boshen force-pushed the 11-30-refactor_semantic_remove_modulerecord_from_semantic_ branch from ca7be00 to 0be5233 Compare November 29, 2024 16:30
Copy link

graphite-app bot commented Nov 29, 2024

Merge activity

@graphite-app graphite-app bot merged commit 0be5233 into main Nov 29, 2024
29 checks passed
@graphite-app graphite-app bot deleted the 11-30-refactor_semantic_remove_modulerecord_from_semantic_ branch November 29, 2024 16:36
Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #7548 will degrade performances by 4.63%

Comparing 11-30-refactor_semantic_remove_modulerecord_from_semantic_ (0be5233) with main (8a788b8)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 11-30-refactor_semantic_remove_modulerecord_from_semantic_ Change
linter[cal.com.tsx] 1.1 s 1.1 s -4.63%
semantic[RadixUIAdoptionSection.jsx] 80.5 µs 74.9 µs +7.5%

This was referenced Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area - Editor and Language Server A-linter Area - Linter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant