feat(parser,linter)!: use a different ModuleRecord for linter
#7554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #7554 will improve performances by 33.04%Comparing Summary
Benchmarks breakdown
|
Boshen
force-pushed
the
11-30-feat_parser_linter_separate_modulerecord_
branch
from
c494062 to
4114497
Compare
Merge activity
|
The parser returns a simple `ModuleRecord` that is allocated in the arena for performance reasons. The linter uses a more complicated, `Send` + `Sync` `ModuleRecord` that will hold more cross-module information. The next step is to return more esm information from the parser to eliminated the need of the `oxc_module_lexer` crate.
Boshen
force-pushed
the
11-30-feat_parser_linter_separate_modulerecord_
branch
from
4114497 to
c2ced15
Compare
graphite-app
bot
deleted the
11-30-feat_parser_linter_separate_modulerecord_
branch
This was referenced Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser returns a simple
ModuleRecordthat is allocated in the arena for performance reasons.The linter uses a more complicated,
Send+SyncModuleRecordthat will hold more cross-module information.The next step is to return more esm information from the parser to eliminated the need of the
oxc_module_lexercrate.