Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove memoffset dependency #7573

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 1, 2024

offset_of! macro became stable in Rust 1.77.0 which is now within our MSRV. Remove the memoffset crate, and use std::mem::offset_of instead.

Copy link

graphite-app bot commented Dec 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Dec 1, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review December 1, 2024 19:50
Copy link

codspeed-hq bot commented Dec 1, 2024

CodSpeed Performance Report

Merging #7573 will not alter performance

Comparing 12-01-chore_deps_remove_memoffset_dependency (e62153b) with main (79014ff)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 1, 2024
Copy link
Contributor Author

overlookmotel commented Dec 1, 2024

Merge activity

  • Dec 1, 6:39 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 1, 6:39 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 1, 6:43 PM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel
Copy link
Contributor Author

Thanks for reviewing, @camc314.

`offset_of!` macro [became stable in Rust 1.77.0](https://doc.rust-lang.org/nightly/core/mem/macro.offset_of.html) which is now within our MSRV. Remove the `memoffset` crate, and use `std::mem::offset_of` instead.
@overlookmotel overlookmotel force-pushed the 12-01-chore_deps_remove_memoffset_dependency branch from a9586b3 to e62153b Compare December 1, 2024 23:39
@graphite-app graphite-app bot merged commit e62153b into main Dec 1, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 12-01-chore_deps_remove_memoffset_dependency branch December 1, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants