Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module_lexer)!: remove oxc_module_lexer #7595

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 3, 2024

This crate will no longer be relevant after we export esm information
directly from the parser.

Besides, ex-module-lexer's output data is too limited for plugin
authors to use.

Copy link

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Dec 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Dec 3, 2024
Copy link

graphite-app bot commented Dec 3, 2024

Merge activity

This crate will no longer be relevant after we export esm information
directly from the parser.

Besides, `ex-module-lexer`'s output data is too limited for plugin
authors to use.
@Boshen Boshen force-pushed the 12-03-feat_module_lexer_remove_oxc_module_lexer_ branch from b79db68 to 943462f Compare December 3, 2024 04:22
@graphite-app graphite-app bot merged commit 943462f into main Dec 3, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 12-03-feat_module_lexer_remove_oxc_module_lexer_ branch December 3, 2024 04:27
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7595 will not alter performance

Comparing 12-03-feat_module_lexer_remove_oxc_module_lexer_ (943462f) with main (be2293a)

Summary

✅ 30 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant