Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(oxc_transformer): use enum to represent Pragma #7613

Closed
wants to merge 1 commit into from

Conversation

IWANABETHATGUY
Copy link
Contributor

No description provided.

Copy link

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY changed the title refactor: use enum in pragma refactor(oxc_transformer): use enum in pragma Dec 3, 2024
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 3, 2024
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review December 3, 2024 14:25
@IWANABETHATGUY IWANABETHATGUY force-pushed the 12-03-refactor_use_enum_in_pragma branch from b1c6720 to a46a9b9 Compare December 3, 2024 14:26
@IWANABETHATGUY IWANABETHATGUY changed the title refactor(oxc_transformer): use enum in pragma refactor(oxc_transformer): use enum to represent Pragma Dec 3, 2024
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7613 will not alter performance

Comparing 12-03-refactor_use_enum_in_pragma (8af7752) with main (b4f3812)

Summary

✅ 29 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY force-pushed the 12-03-refactor_use_enum_in_pragma branch from a46a9b9 to 5b50a9f Compare December 3, 2024 15:19
@IWANABETHATGUY IWANABETHATGUY force-pushed the 12-03-refactor_use_enum_in_pragma branch from 5b50a9f to 8af7752 Compare December 3, 2024 15:22
@overlookmotel
Copy link
Contributor

@IWANABETHATGUY Oh I'm sorry. I didn't realize you were working on this.

@overlookmotel
Copy link
Contributor

One question, if you don't mind me asking: Same as in #7553, here you Box the result of the various match arms. What's the advantage of doing that?

@IWANABETHATGUY
Copy link
Contributor Author

One question, if you don't mind me asking: Same as in #7553, here you Box the result of the various match arms. What's the advantage of doing that?

No special reason, I saw your code and I think it is better than me, I just don't realize early return could avoid Boxing a iter trait.

@IWANABETHATGUY IWANABETHATGUY deleted the 12-03-refactor_use_enum_in_pragma branch December 4, 2024 02:50
@overlookmotel
Copy link
Contributor

Ah ha now I understand the Box. Thanks for explaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants