Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oxc): remove oxc_napi crate #7634

Merged
merged 1 commit into from
Dec 4, 2024
Merged

feat(oxc): remove oxc_napi crate #7634

merged 1 commit into from
Dec 4, 2024

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 4, 2024

napi has a limitation, it cannot feature gate type exposure.

closes #7623

Copy link

graphite-app bot commented Dec 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Dec 4, 2024
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #7634 will not alter performance

Comparing fix-napi-2 (aba9553) with main (543df6e)

Summary

✅ 29 untouched benchmarks

napi has a limitation, it cannot feature gate type exposure.
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
Copy link
Member Author

Boshen commented Dec 4, 2024

Merge activity

  • Dec 3, 9:00 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 3, 9:00 PM EST: A user added this pull request to the Graphite merge queue.

@Boshen Boshen merged commit 771c698 into main Dec 4, 2024
26 checks passed
@Boshen Boshen deleted the fix-napi-2 branch December 4, 2024 02:07
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant