Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): use ModuleRecord::has_module_syntax for setting sourceType #7646

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 4, 2024

No description provided.

Copy link

graphite-app bot commented Dec 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Dec 4, 2024

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 4, 2024
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #7646 will not alter performance

Comparing 12-04-refactor_parser_use_modulerecord_has_module_syntax_for_setting_sourcetype (36d1493) with main (d503a84)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
Copy link
Member Author

Boshen commented Dec 4, 2024

Merge activity

  • Dec 4, 7:51 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 4, 7:51 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 4, 7:57 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 12-04-refactor_parser_use_modulerecord_has_module_syntax_for_setting_sourcetype branch from 2fb74ef to 36d1493 Compare December 4, 2024 12:52
@graphite-app graphite-app bot merged commit 36d1493 into main Dec 4, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 12-04-refactor_parser_use_modulerecord_has_module_syntax_for_setting_sourcetype branch December 4, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant