Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(linter): add more tests fo rules-of-hooks #7683

Merged

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Dec 5, 2024

closes #6651

Copy link

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@camc314 camc314 marked this pull request as ready for review December 5, 2024 15:10
Copy link
Contributor Author

camc314 commented Dec 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-linter Area - Linter label Dec 5, 2024
@camc314 camc314 changed the title tests(linter): add more tests fo rules-of-hooks test(linter): add more tests fo rules-of-hooks Dec 5, 2024
@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Dec 5, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
Copy link
Member

Boshen commented Dec 5, 2024

Merge activity

  • Dec 5, 10:17 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 5, 10:17 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 5, 10:23 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the c/12-05-tests_linter_add_more_tests_fo_rules-of-hooks branch from aabd577 to be9863a Compare December 5, 2024 15:18
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #7683 will not alter performance

Comparing c/12-05-tests_linter_add_more_tests_fo_rules-of-hooks (be9863a) with main (1925ddc)

Summary

✅ 29 untouched benchmarks

@bensaufley
Copy link

🙏🏻 Thanks!

@graphite-app graphite-app bot merged commit be9863a into main Dec 5, 2024
24 checks passed
@graphite-app graphite-app bot deleted the c/12-05-tests_linter_add_more_tests_fo_rules-of-hooks branch December 5, 2024 15:23
@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: eslint-plugin-react-hooks(rules-of-hooks) fires when it doesn't in ESLint for a wrapped component
3 participants