Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(transformer): conformance runner use HelperLoaderMode::External in takeover mode #7807

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 11, 2024

In "takeover" mode, transformer conformance test runner was using HelperLoaderMode::Runtime. Switch this to HelperLoaderMode::External to match standard test runner mode.

Copy link

graphite-app bot commented Dec 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Dec 11, 2024
@overlookmotel overlookmotel marked this pull request as ready for review December 11, 2024 16:05
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 11, 2024
Copy link

graphite-app bot commented Dec 11, 2024

Merge activity

…` in takeover mode (#7807)

In "takeover" mode, transformer conformance test runner was using `HelperLoaderMode::Runtime`. Switch this to `HelperLoaderMode::External` to match standard test runner mode.
@overlookmotel overlookmotel force-pushed the 12-11-test_transformer_conformance_runner_use_helperloadermode_external_in_takeover_mode branch from 59265ab to 450bb33 Compare December 11, 2024 16:07
@graphite-app graphite-app bot merged commit 450bb33 into main Dec 11, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 12-11-test_transformer_conformance_runner_use_helperloadermode_external_in_takeover_mode branch December 11, 2024 16:11
Copy link

codspeed-hq bot commented Dec 11, 2024

CodSpeed Performance Report

Merging #7807 will not alter performance

Comparing 12-11-test_transformer_conformance_runner_use_helperloadermode_external_in_takeover_mode (450bb33) with main (afaaffa)

Summary

✅ 29 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant