fix(transformer/class-properties): fix symbol clashes in instance prop initializers

[overlookmotel]

Instance property initializers are moved into constructor. If symbols they reference are shadowed within constructor, rename those symbols.

Input:

class C {
  prop = foo();
  constructor(foo) {
    console.log(foo);
  }
}

Output:

class C {
  constructor(_foo) { // <-- renamed
    this.prop = foo(); // <-- moved into constructor
    console.log(_foo); // <-- renamed
  }
}

[overlookmotel]

• perf(transformer/class-properties): reduce work updating scopes when transforming static prop initializers #7904
• perf(transformer/class-properties): fast path for instance prop initializer scope re-parenting #7901
• feat(transformer/class-properties): only rename symbols if necessary #7896
• fix(transformer/class-properties): fix symbol clashes in instance prop initializers #7872 👈 (View in Graphite)
• feat(traverse): add TraverseScoping::rename_symbol method #7871
• fix(semantic): ScopeTree::rename_binding preserve order of bindings #7870
• refactor(semantic): SymbolTable::set_name return old name #7869
• refactor(semantic)!: remove SymbolTable::rename method #7868
• refactor(transformer/class-properties): instance prop inits visitor use Visit #7867
• fix(transformer/class-properties): use UID for args in created class constructor #7866
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #7872 will not alter performance

_{Comparing 12-13-fix_transformer_class-properties_fix_symbol_clashes_in_instance_prop_initializers (e76fbb0) with main (3858221)}

Summary

✅ 29 untouched benchmarks

[graphite-app]

Merge activity

• Dec 14, 8:52 PM EST: A user added this pull request to the Graphite merge queue.
• Dec 14, 8:57 PM EST: A user merged this pull request with the Graphite merge queue.