Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add the import/no_named_default rule #7902

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

Spoutnik97
Copy link
Contributor

No description provided.

Copy link

graphite-app bot commented Dec 14, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 14, 2024
Copy link

codspeed-hq bot commented Dec 14, 2024

CodSpeed Performance Report

Merging #7902 will not alter performance

Comparing Spoutnik97:linter/no-named-default (c868d1f) with main (46e2e27)

Summary

✅ 29 untouched benchmarks

@Spoutnik97 Spoutnik97 force-pushed the linter/no-named-default branch from 7ae5431 to adca0d6 Compare December 14, 2024 23:08
@Sysix
Copy link
Contributor

Sysix commented Dec 14, 2024

this is in the wrong folder?

this should be: crates/oxc_linter/src/rules/import/no_named_default.rs

crates/oxc_linter/src/rules.rs Outdated Show resolved Hide resolved
@Spoutnik97 Spoutnik97 force-pushed the linter/no-named-default branch from adca0d6 to c6e9272 Compare December 16, 2024 20:47
@Spoutnik97 Spoutnik97 force-pushed the linter/no-named-default branch from c6e9272 to 5fd4df6 Compare December 16, 2024 21:13
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Boshen Boshen merged commit 25ddb35 into oxc-project:main Dec 17, 2024
26 checks passed
Boshen added a commit that referenced this pull request Dec 17, 2024
## [0.15.3] - 2024-12-17

### Features

- 25ddb35 linter: Add the import/no_named_default rule (#7902)
(Guillaume Piedigrossi)
- ee26b44 linter: Enhance `get_element_type` to resolve more element
types (#7885) (dalaoshu)

### Bug Fixes

- 6f41d92 linter: False positive in `unicorn/no-useless-spread` (#7940)
(dalaoshu)
- 0867b40 linter: Fix configuration parser for `no-restricted-imports`
(#7921) (Alexander S.)
- 9c9b73d linter: Fix incorrect fixer for `prefer-regexp-test` (#7898)
(Cameron)
- 32935e6 linter: False positive in
`jsx-a11y/label-has-associated-control` (#7881) (dalaoshu)
- 14c51ff semantic: Remove inherting `ScopeFlags::Modifier` from parent
scope (#7932) (Dunqing)

### Refactor

- 3858221 global: Sort imports (#7883) (overlookmotel)
- b99ee37 linter: Move rule "no-restricted-imports" to nursery (#7897)
(Alexander S.)
- ff2a68f linter/yoda: Simplify code (#7941) (overlookmotel)

### Styling

- 7fb9d47 rust: `cargo +nightly fmt` (#7877) (Boshen)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants