refactor(transformer/class-properties): make transform_instance_assignment_expression more generic
#7956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
changed the title
transform_instance_assignment_expression more generic
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #7956 will not alter performanceComparing Summary
|
Boshen
changed the base branch from
12-17-docs_transformer_class-properties_remove_oudated_todo_for_assignment_expression
to
graphite-base/7956
Boshen
force-pushed
the
12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic
branch
from
3617e34 to
18eba77
Compare
Boshen
force-pushed
the
graphite-base/7956
branch
from
e02c28e to
18441af
Compare
Boshen
force-pushed
the
12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic
branch
from
18eba77 to
a00c9b4
Compare
…nment_expression more generic
Dunqing
force-pushed
the
12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic
branch
from
a00c9b4 to
79767e8
Compare
…nment_expression more generic
Dunqing
force-pushed
the
12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic
branch
from
79767e8 to
8a4be03
Compare
Boshen
deleted the
12-17-refactor_transformer_class-properties_make_transform_instance_assignment_expression_more_generic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function can also transform super assignment expressions, but it needs to use different helper functions and has different parameters. Transform this function to accept getter(_classPrivateFieldGet2) and setter(_classPrivateFieldSet2) functions.