Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): remove unused set_rules method #8030

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Dec 19, 2024

this method is unused, hence it makes sense to remove.
furthermore, keeping it makes it tricky to work the nested config stuff

@camc314 camc314 marked this pull request as ready for review December 19, 2024 21:24
Copy link
Contributor Author

camc314 commented Dec 19, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 19, 2024
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #8030 will not alter performance

Comparing c/12-19-refactor_linter_remove_unused_set_rules_method (83136ba) with c/12-19-refactor_linter_remove_unused_with_rules_method (3262b86)

Summary

✅ 29 untouched benchmarks

@camc314
Copy link
Contributor Author

camc314 commented Dec 19, 2024

looks like clippy is stopping me from doing this in two separte PRs 🙂

@camc314 camc314 closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant