Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): false positiver in private member expr in oxc/const-comparison #8164

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Dec 28, 2024

fixes #8163

@camc314 camc314 marked this pull request as ready for review December 28, 2024 13:36
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Dec 28, 2024
Copy link
Contributor Author

camc314 commented Dec 28, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Dec 28, 2024

CodSpeed Performance Report

Merging #8164 will not alter performance

Comparing c/12-28-fix_linter_false_positiver_in_private_member_expr_in_oxc_const-comparison (1b9a5ba) with main (37c9959)

Summary

✅ 29 untouched benchmarks

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 28, 2024
Copy link
Contributor Author

camc314 commented Dec 28, 2024

Merge activity

  • Dec 28, 8:48 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 28, 8:48 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 28, 8:54 AM EST: A user merged this pull request with the Graphite merge queue.

@camc314 camc314 force-pushed the c/12-28-fix_linter_false_positiver_in_private_member_expr_in_oxc_const-comparison branch from 4f31ea4 to 1b9a5ba Compare December 28, 2024 13:49
@graphite-app graphite-app bot merged commit 1b9a5ba into main Dec 28, 2024
25 checks passed
@graphite-app graphite-app bot deleted the c/12-28-fix_linter_false_positiver_in_private_member_expr_in_oxc_const-comparison branch December 28, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(linter): false positive in oxc/const-comparisons
1 participant