feat(linter): add jsx-a11y/no-noninteractive-tabindex rule #8167
+250
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #8167 will not alter performanceComparing Summary
|
camc314
reviewed
Dec 28, 2024
crates/oxc_linter/src/rules/jsx_a11y/no_noninteractive_tabindex.rs
Outdated
Show resolved
Hide resolved
|
I added comments regarding the interactive html roles and elements, because it's convenient to have linked resources to relevant official spec sections, and specifically an explanation regarding the tabpanel role. If this is not desired I can remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the jsx-a11y/no-noninteractive-tabindex rule.
I set the default values as the ones that are in the recommended config.
I used this html spec section to source the interactive elements.
The interactive roles came from this article in the MDN docs.