Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minifier): move drop_use_strict_directives_if_function_is_empty to PeepholeRemoveDeadCode #8174

Conversation

sapphi-red
Copy link
Contributor

No description provided.

Copy link
Contributor Author

sapphi-red commented Dec 29, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Dec 29, 2024

CodSpeed Performance Report

Merging #8174 will not alter performance

Comparing 12-29-fix_minifier_move_drop_use_strict_directives_if_function_is_empty_to_peepholeremovedeadcode (ee80f63) with 12-29-feat_minifier_remove_unnecessary_use_strict_ (39eeb7b)

Summary

✅ 29 untouched benchmarks

@sapphi-red sapphi-red deleted the 12-29-fix_minifier_move_drop_use_strict_directives_if_function_is_empty_to_peepholeremovedeadcode branch December 29, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant