Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): change foo?.['bar'] to foo?.bar #8176

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Dec 29, 2024

ChainExpression's expression field is ChainElement and not Expression so the previous code did not run for optional chainings.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Dec 29, 2024
Copy link
Contributor Author

sapphi-red commented Dec 29, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Dec 29, 2024

CodSpeed Performance Report

Merging #8176 will not alter performance

Comparing 12-29-feat_minifier_change_foo_.bar_to_foo.bar_ (abafdfd) with 12-29-test_minifier_port_tests_from_converttodottedpropertiestest (5d4e172)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 29, 2024
Copy link
Member

Boshen commented Dec 29, 2024

Merge activity

  • Dec 29, 2:15 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 29, 2:15 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 29, 2:19 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Dec 30, 3:20 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 29, 2024
@Boshen Boshen changed the base branch from 12-29-test_minifier_port_tests_from_converttodottedpropertiestest to graphite-base/8176 December 29, 2024 07:19
@Boshen Boshen force-pushed the 12-29-feat_minifier_change_foo_._bar_to_foo_.bar_ branch from abafdfd to 204c5e8 Compare December 30, 2024 08:09
@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-cli Area - CLI A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-editor Area - Editor and Language Server labels Dec 30, 2024
@Boshen Boshen changed the base branch from graphite-base/8176 to main December 30, 2024 08:19
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 30, 2024
@Boshen Boshen merged commit cef8eb8 into main Dec 30, 2024
3 checks passed
@Boshen Boshen deleted the 12-29-feat_minifier_change_foo_._bar_to_foo_.bar_ branch December 30, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-cli Area - CLI A-codegen Area - Code Generation A-editor Area - Editor and Language Server A-linter Area - Linter A-minifier Area - Minifier A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants