Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minifier): minify string PropertyKey #8177

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Dec 29, 2024

#8169 added if self.in_fixed_loop in try_compress_property_key. Because exit_property_key was not called for PeepholeOptimizations, try_compress_property_key was never called.

refs #8147

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Dec 29, 2024
@sapphi-red sapphi-red marked this pull request as ready for review December 29, 2024 06:21
Copy link

codspeed-hq bot commented Dec 29, 2024

CodSpeed Performance Report

Merging #8177 will not alter performance

Comparing 12-29-fix_minifier_minify_string_propertykey_ (75d5f17) with main (1fa5341)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 29, 2024
Copy link
Member

Boshen commented Dec 29, 2024

Merge activity

  • Dec 29, 2:15 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 29, 2:15 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 29, 2:20 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Dec 29, 2:49 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 29, 2:49 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 29, 2:54 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 29, 2024
@Boshen Boshen force-pushed the 12-29-fix_minifier_minify_string_propertykey_ branch from c728918 to 9d80ac5 Compare December 29, 2024 07:37
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 29, 2024
#8169 added `if self.in_fixed_loop` in `try_compress_property_key`. Because `exit_property_key` was not called for `PeepholeOptimizations`, `try_compress_property_key` was never called.

refs #8147
@Boshen Boshen force-pushed the 12-29-fix_minifier_minify_string_propertykey_ branch from 9d80ac5 to 75d5f17 Compare December 29, 2024 07:49
@graphite-app graphite-app bot merged commit 75d5f17 into main Dec 29, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 12-29-fix_minifier_minify_string_propertykey_ branch December 29, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants