Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(semantic): report errors for missing function implementations #8196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(semantic): report errors for missing function implementations #8196

wants to merge 1 commit into from
+181 −21

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Dec 30, 2024

No description provided.

@camc314 camc314 marked this pull request as ready for review December 30, 2024 20:55
@github-actions github-actions bot added A-semantic Area - Semantic C-enhancement Category - New feature or request labels Dec 30, 2024
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Dec 30, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 30, 2024

CodSpeed Performance Report

Merging #8196 will not alter performance

Comparing c/12-30-feat_semantic_report_errors_for_missing_function_implementations (df39fd7) with main (ccaa9f7)

Summary

✅ 29 untouched benchmarks

Boshen
Boshen reviewed Dec 31, 2024
View reviewed changes
crates/oxc_semantic/src/checker/typescript.rs

pub fn check_stmts(stmts: &oxc_allocator::Vec<'_, Statement<'_>>, ctx: &SemanticBuilder<'_>) {
if !ctx.source_type.is_typescript_definition() {
for (a, b) in stmts.iter().map(Some).chain(vec![None, None]).tuple_windows() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walking over the statements again is not efficient, probably need some better algorithm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The smaller allocation (vec![None, None]) is also not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen left review comments

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees
No one assigned
Labels
A-semantic Area - Semantic C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camc314 @Boshen