Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): implement eslint-plugin-unicorn/no-thenable rule #910

Merged
merged 7 commits into from
Sep 16, 2023
Merged

feat(linter): implement eslint-plugin-unicorn/no-thenable rule #910

merged 7 commits into from
Sep 16, 2023

Conversation

Devin-Yeung
Copy link
Contributor

related to #684

@github-actions github-actions bot added the A-linter Area - Linter label Sep 14, 2023
@Devin-Yeung
Copy link
Contributor Author

Devin-Yeung commented Sep 14, 2023 •
edited
Loading

It's almost done, I will find some time to:

  • fix clippy warning
  • write doc

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 14, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #910 will not alter performance

Comparing Devin-Yeung:no-thenable (ffdbde9) with main (dd74d93)

Summary

✅ 18 untouched benchmarks

@Devin-Yeung Devin-Yeung marked this pull request as ready for review September 15, 2023 07:30
@Boshen Boshen merged commit 4bf329e into oxc-project:main Sep 16, 2023
@Devin-Yeung Devin-Yeung deleted the no-thenable branch September 16, 2023 11:41
@camc314 camc314 mentioned this pull request Nov 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysteryven mysteryven mysteryven left review comments

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Devin-Yeung @Boshen @mysteryven