Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer): Shorthand Properties #960

Merged

Conversation

magic-akari
Copy link
Contributor

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 6, 2023

CodSpeed Performance Report

Merging #960 will not alter performance

Comparing magic-akari:feat/transformer/shorthand-propertys (83bb582) with main (5045853)

Summary

✅ 18 untouched benchmarks

@magic-akari magic-akari force-pushed the feat/transformer/shorthand-propertys branch from 9839544 to ce86150 Compare October 6, 2023 14:12
@magic-akari magic-akari marked this pull request as ready for review October 6, 2023 14:34
@magic-akari
Copy link
Contributor Author

No test cases, 不安です。

@github-actions github-actions bot added the A-ast Area - AST label Oct 6, 2023
@Boshen
Copy link
Member

Boshen commented Oct 6, 2023

No test cases, 不安です。

Take a look at the integration tests located at tasks/transform_conformance/src/lib.rs

@Boshen
Copy link
Member

Boshen commented Oct 6, 2023

No test cases, 不安です。

Take a look at the integration tests located at tasks/transform_conformance/src/lib.rs

Run it with just watch 'run -p oxc_transform_conformance'

@magic-akari magic-akari requested a review from Boshen October 7, 2023 08:50
@Boshen Boshen merged commit 21066a9 into oxc-project:main Oct 7, 2023
18 checks passed
@magic-akari magic-akari deleted the feat/transformer/shorthand-propertys branch October 7, 2023 09:03
@Boshen
Copy link
Member

Boshen commented Oct 7, 2023

Thank you @magic-akari! You may try some of the harder ones that don't require symbol or scope resolution. Even passing a small test case will go a long way.

@Boshen Boshen added the A-transformer Area - Transformer / Transpiler label Oct 10, 2023
@Boshen Boshen mentioned this pull request Oct 10, 2023
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants