Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transformer): Class Static Block #962

Merged
merged 6 commits into from
Oct 8, 2023
Merged

feat(transformer): Class Static Block #962

merged 6 commits into from
Oct 8, 2023

Conversation

magic-akari
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the A-ast Area - AST label Oct 7, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 7, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #962 will not alter performance

Comparing magic-akari:feat/transformer/class-static-block (412f3a3) with main (a710e73)

Summary

✅ 18 untouched benchmarks

@magic-akari magic-akari marked this pull request as ready for review October 7, 2023 13:56
Boshen
Boshen reviewed Oct 7, 2023
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive! Just a few nitpicks.

crates/oxc_transformer/src/es2022/class_static_block.rs Outdated Show resolved Hide resolved
crates/oxc_transformer/src/es2022/class_static_block.rs Outdated Show resolved Hide resolved
@Boshen Boshen enabled auto-merge (squash) October 7, 2023 14:45
@Boshen Boshen merged commit 9ad2634 into oxc-project:main Oct 8, 2023
18 checks passed
@Boshen Boshen added the A-transformer Area - Transformer / Transpiler label Oct 10, 2023
@Boshen Boshen mentioned this pull request Oct 10, 2023
Closed
51 tasks
@magic-akari magic-akari deleted the feat/transformer/class-static-block branch October 26, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-ast Area - AST A-transformer Area - Transformer / Transpiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magic-akari @Boshen