Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer): RegexpFlags #977

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

magic-akari
Copy link
Contributor

I use a different strategy than Babel. (but same with swc)
I converted unsupported Regexp flags into RegExp constructors so they can be polyfilled by users.

@magic-akari magic-akari marked this pull request as ready for review October 10, 2023 15:26
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 10, 2023

CodSpeed Performance Report

Merging #977 will not alter performance

Comparing magic-akari:regex (4fcd129) with main (d5fb3d4)

Summary

✅ 22 untouched benchmarks

@magic-akari magic-akari marked this pull request as draft October 10, 2023 15:40
@magic-akari magic-akari marked this pull request as ready for review October 10, 2023 15:55
Copy link
Contributor

@mysteryven mysteryven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learn a lot from this implementation!

@magic-akari magic-akari merged commit dc08c94 into oxc-project:main Oct 11, 2023
18 checks passed
@magic-akari magic-akari deleted the regex branch October 26, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants