Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codegen): move minifying printer to codegen crate #985

Merged
merged 1 commit into from
Oct 12, 2023
Merged

feat(codegen): move minifying printer to codegen crate #985

merged 1 commit into from
Oct 12, 2023

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Oct 12, 2023

No description provided.

@Boshen Boshen requested a review from mysteryven October 12, 2023 06:35
@github-actions github-actions bot added A-minifier Area - Minifier A-printer Area - Printer labels Oct 12, 2023
@Boshen Boshen merged commit 809f050 into main Oct 12, 2023
16 checks passed
@Boshen Boshen deleted the codegen branch October 12, 2023 06:56
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 12, 2023

CodSpeed Performance Report

Merging #985 will improve performances by 64.6%

Comparing codegen (a9b5e6f) with main (f28d96c)

Summary

⚡ 4 improvements
✅ 18 untouched benchmarks

Benchmarks breakdown

Benchmark main codegen Change
⚡ minifier[vue.js] 188.9 ms 114.8 ms +64.6%
⚡ minifier[typescript.js] 4.1 s 2.7 s +51.32%
⚡ minifier[antd.js] 2.8 s 2 s +35.73%
⚡ minifier[react.development.js] 31.6 ms 20.4 ms +54.83%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysteryven mysteryven Awaiting requested review from mysteryven

Assignees
No one assigned
Labels
A-minifier Area - Minifier A-printer Area - Printer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Boshen