Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transform_conformance): move Formatter to codegen #986

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Oct 12, 2023

No description provided.

@github-actions github-actions bot added the A-minifier Area - Minifier label Oct 12, 2023
@Boshen Boshen force-pushed the transform_conformance_codegen branch from 4f72dd2 to 886c408 Compare October 12, 2023 07:06
@Boshen
Copy link
Member Author

Boshen commented Oct 12, 2023

Everything is failing in the conformance tests due to codegen not printing things (e.g. semicolons) properly, I'll fix it in the next PR.

@Boshen Boshen merged commit ce79bc1 into main Oct 12, 2023
@Boshen Boshen deleted the transform_conformance_codegen branch October 12, 2023 07:13
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 12, 2023

CodSpeed Performance Report

Merging #986 will not alter performance

Comparing transform_conformance_codegen (886c408) with main (809f050)

Summary

✅ 22 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant