Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

shippo: add HTTP test coverage #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

20k-ultra
Copy link
Contributor

@20k-ultra 20k-ultra commented Mar 17, 2022

Tests all shippo lib functions if they deserialize raw JSON correctly. Includes tests for pagination as well.

shippo/tests/http_test.rs Outdated Show resolved Hide resolved
@20k-ultra 20k-ultra marked this pull request as ready for review March 22, 2022 05:41
@20k-ultra
Copy link
Contributor Author

ready for review

@20k-ultra
Copy link
Contributor Author

Tests are failing because of cio_api. Other commits also have this failure so I do not suspect this PR to have introduced this.

failures:

---- applicants::tests::test_serialize_deserialize_applicants stdout ----
 INFO  tracing::span > new
thread 'applicants::tests::test_serialize_deserialize_applicants' panicked at 'called `Result::unwrap()` on an `Err` value: Timeout', cio/src/applicants.rs:2889:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    applicants::tests::test_serialize_deserialize_applicants

test result: FAILED. 7 passed; 1 failed; 7 ignored; 0 measured; 0 filtered out; finished in 30.00s

error: test failed, to rerun pass '-p cio-api --lib'
Error: Process completed with exit code 101.

@20k-ultra 20k-ultra force-pushed the shippo-add-tests branch 2 times, most recently from cb0cf7e to 0623369 Compare March 29, 2022 03:59
@20k-ultra
Copy link
Contributor Author

I'm still getting the same error after rebasing master and I see in master commits are passing so i'll look into it.

@20k-ultra
Copy link
Contributor Author

hey @jessfraz, if I figure out the tests do you think this would get merged ? I spent a good bit of time on it so hoping it does.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant