Update rust toolchain to 1.84 #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2025 19:47
A bunch of just clippy and warning changes that came with the 1.84 version.
|
This should also unlock turning back on tests for VCRs with multiple sub-volumes. |
mkeeter
reviewed
Jan 10, 2025
measure_iops/src/main.rs
Outdated
| @@ -64,7 +64,7 @@ pub fn opts() -> Result<Opt> { | |||
|
|
|||
| macro_rules! ceiling_div { | |||
There was a problem hiding this comment.
...can we just delete this macro?
There was a problem hiding this comment.
Yes, done in 5606876
mkeeter
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of just clippy and warning changes that came with the 1.84 version.