Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFD site asciidoc fixes #46

Merged
merged 13 commits into from
Nov 14, 2023
Merged

RFD site asciidoc fixes #46

merged 13 commits into from
Nov 14, 2023

Conversation

benjaminleonard
Copy link
Collaborator

@benjaminleonard benjaminleonard commented Aug 22, 2023

As I work through parity between react-asciidoc and the native renderer I am merging some of the fixes upstream here.

📦 Published PR as canary version: 1.2.5--canary.46.3e5514d.0

✨ Test out this PR locally via:

npm install @oxide/[email protected]
# or 
yarn add @oxide/[email protected]

@benjaminleonard benjaminleonard added the patch Increment the patch version when merged label Aug 22, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 360 files.

Valid Invalid Ignored Fixed
172 1 187 0
Click to see the invalid file list
  • components/src/asciidoc/Section.tsx

components/src/asciidoc/Section.tsx Show resolved Hide resolved
components/src/asciidoc/Section.tsx Show resolved Hide resolved
@benjaminleonard
Copy link
Collaborator Author

Hmm — including the Section here causes it to ignore (client side) the overrides I'm setting up in the RFD site. I'm guessing because this has it's own <Content> component that is untouched.

@benjaminleonard benjaminleonard merged commit 3e5514d into master Nov 14, 2023
3 checks passed
@benjaminleonard benjaminleonard deleted the rfd-site-asciidoc-fixes branch November 14, 2023 19:35
@zephraph
Copy link
Contributor

🚀 PR was released in v1.2.5 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants