Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: enable basic tab completion for bash #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

citrus-it
Copy link
Contributor

@citrus-it citrus-it commented Apr 19, 2024

This gets basic tab completion working for bash builtins and for various illumos commands that take a zone name -- most usefully zlogin.

It also adds oxlog's location to the PATH in the GZ, where it's most often used.

@citrus-it citrus-it requested review from jclulow and jgallagher April 19, 2024 18:14
@jclulow
Copy link
Collaborator

jclulow commented Apr 19, 2024

I will have a look at this! I think we could maybe do something with a small Rust program here to avoid all the bash logic.

@citrus-it
Copy link
Contributor Author

I think we should merge the small fragment that is in this branch now to get into the next release, and we can circle back later with a better solution if there is one.

@jclulow
Copy link
Collaborator

jclulow commented Apr 28, 2024

With my apologies for the delay, I've pushed up what I came up with here: https://github.com/oxidecomputer/helios-bash-completion

Can you try it to see if it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants