Final(?) fixes for Oxcon board. #1542
Conversation
cbiffle
force-pushed
the
oxcon2023g0-fixes
branch
2 times, most recently
from
49759b7 to
06f1681
Compare
| led_on(led); | ||
| self.blink_state = false; | ||
|
|
||
| if !any_blinking { |
There was a problem hiding this comment.
I'd suggest keeping the led_on(led) call here, so that going from off to blinking is obviously right away (otherwise, you have to wait for a BLINK_INTERVAL).
There was a problem hiding this comment.
So, in practice, if I leave that line in, the LED starts off. I'm not sure why. Was it blinking immediately before?
There was a problem hiding this comment.
That confuses me! The point of this line was to get immediate feedback when calling led_blink (if other LEDs weren't already blinking), and I'm pretty sure it worked. I'd have to think through it a little more to understand why it's not working in this case.
There was a problem hiding this comment.
Yeah, I assumed it had something to do with the previously ambiguous nature of blink_state (where blink_state of false appeared to mean on?). But, had to remove this to make the feedback immediate.
cbiffle
force-pushed
the
oxcon2023g0-fixes
branch
3 times, most recently
from
43768a0 to
db16b8c
Compare
- Add insomniac feature to suppress sleep at WFI because Humility doesn't know how to attach to an STM32G0 that is sleeping. - Fix bug in user leds "blink on start" feature that failed to actually set up blink on start, because there are several pieces of data to update and I missed two of them. I've simplified it. - Remap to make pins A9 and A10 available -- they're muxed away on G0 by default and need to be activated (see main). Extra fun because the relevant bits in the PAC are wrong. - Fix I2C pin mapping for the actual fabbed board. - Activate PLL and boost CPU to 64 MHz for bragging rights. - Adjust I2C clock configuration to account for that.
cbiffle
force-pushed
the
oxcon2023g0-fixes
branch
from
db16b8c to
0947e60
Compare
Add insomniac feature to suppress sleep at WFI because Humility
doesn't know how to attach to an STM32G0 that is sleeping.
Fix bug in user leds "blink on start" feature that failed to actually
set up blink on start, because there are several pieces of data to
update and I missed two of them.