Make build output reproducible #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbott
force-pushed
the
reproducible
branch
from
1b4ada0 to
08d9aa1
Compare
Currently the build code may emit structures/enums in a different order each build. This produces correct code but is not reproducible. Ensure the build output happens the same way each time by sorting before outputing. We don't actually care how things are sorted, only that they are sorted.
labbott
force-pushed
the
reproducible
branch
from
08d9aa1 to
a58a433
Compare
mkeeter
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the build code may emit structures/enums in a different order each build. This produces correct code but is not reproducible. Ensure the build output happens the same way each time by sorting before outputing. We don't actually care how things are sorted, only that they are sorted.