build/util: prevent infinite loop if target/ not found #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbott
approved these changes
Dec 10, 2024
Previously, if you attempted to use certain functions in the build_util crate...and your output directory happened to not include any parent directories with the exact name "target"... ...the build script would burn 100% of a core forever, until you killed it. This doesn't affect Hubris-proper but _does_ affect out of tree builds. The original code was arguably wrong anyway, so, this fixes that.
cbiffle
force-pushed
the
cbiffle/build-util-infinite-loop
branch
from
32d7585 to
a5a0335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you attempted to use certain functions in the build_util crate...and your output directory happened to not include any parent directories with the exact name "target"...
...the build script would burn 100% of a core forever, until you killed it.
This doesn't affect Hubris-proper but does affect out of tree builds. The original code was arguably wrong anyway, so, this fixes that.