Sidecar FPFAs: pick up I2C SCL stretch fix #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanaelhuffman
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
lgtm. My only comment is that the artifacts at the GHA links you're referencing aren't permanent and will be rolled over within 90 days. If you want a permanent link to the artifacts, I think we'd have to make a quartz gh release and upload the build results there. I have open issues to improve this process but we don't have an automated solve here yet so FYI.
|
I updated the readme to point to the commit itself for now. We can always recreate the same image given the git rev and OS/toolchain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pickup oxidecomputer/quartz@d4c2c02.
I'm updating the Front IO FPGAs as they're the primary thing impacted here, but I'm also updating the mainboard FPGA as it has an I2C interface to the Tofino 2.
The FPGAs are no longer built with Buildomat so I've updated their READMEs accordingly. Additionally, I am pulling in an updated front IO register map after the fix in oxidecomputer/quartz@39d93cd which results in a bunch of erroneous code getting pulled out of the HTML file.