WIP - Measure the SP on SP_RESET signal interrupt #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add interrupt-related API calls to the LPC55 `gpio_driver`.
A task on an LPC55 can now configue and use GPIO interrupts.
app.toml example shows Pin Interrupt configuration:
[tasks.foo]
...
interrupts = { "pint.irq0" = "button-irq" }
...
task-slots = ["gpio_driver", ...]
[tasks.foo.config]
pins = [
{ name="BUTTON', pin={ port=1, pin=9}, alt=0, pint=0, direction="input", opendrain="normal" }
]
…API.
The functions:
fn {clear,detected,disable,enable}_{rising,falling,status}(PintSlot)
and
fn read_pint_status(...)
become
fn pint_op(PintSlot, PintOp, PintCondition)
This leaves a couple permutations not covered (enable/disable
interrupt at the NVIC level).
Those can are left as no-ops for the time being.
Future: The unimplemented combinations could return an error/fault
if called.
…EADME.md Feedback response: Fix idl/lpc55-pins.idol to use Option<PintSlot>. Feedback response: Collapse the many PINT calls in lpc55-pins.idol to one `pint_op`
Generate separate GPIO pin setup functions for named pins. This allows easier switching between pin configurations at runtime.
Hiffy commands db_measure_sp and db_reset_sp are there temporarily for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. Measurement currently takes 12.8s and we'd like to improve that or accommodate that delay before merging.
That's in addition to any feedback that people may have.
Testing SP measurement
Checkout hubris branch
attest-spMeasure on SP Reset:
Hit the reset button on the SP or use the SpCtrl.db_reset_sp function:
humility --archive=$ARCHIVE hiffy -c SpCtrl.db_reset_sp -a delay_ms=10 sleep 13See traces
The ringbuf trace in
swdandattesttasks have the interesting information including the time expended:humility --archive=$ARCHIVE ringbufDump the attestation log:
humility --archive=$ARCHIVE hiffy -c Attest.log -a offset=0 -n 256 -o out hexdump -C outRun the measurement without resetting the SP:
humility --archive=$ARCHIVE hiffy -T20 -c SpCtrl.db_measure_spNotes
attesttask needs areset_log_and_recordfunction usable only by theswdtask.attesttask. Is that the right thing to do? TBD.db_measure_spanddb_reset_spare there for development and will be removed before merge. It should be sufficient to reset the SP if attestation needs to be refreshed.