Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly push negated OxQL predicates into the database #6741

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Correctly push negated OxQL predicates into the database #6741

merged 2 commits into from
Oct 2, 2024

Conversation

bnaecker
Copy link
Collaborator

@bnaecker bnaecker commented Oct 1, 2024

Fixes #6740

@bnaecker bnaecker requested a review from bcantrill October 1, 2024 21:12
bcantrill
bcantrill approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@bcantrill bcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find -- fix looks great!

@bnaecker bnaecker enabled auto-merge (squash) October 1, 2024 21:58
@bnaecker bnaecker merged commit b154c06 into main Oct 2, 2024
16 checks passed
@bnaecker bnaecker deleted the fix-oxql-filter-negation branch October 2, 2024 01:20
hawkw pushed a commit that referenced this pull request Oct 2, 2024
@bnaecker @hawkw
Correctly push negated OxQL predicates into the database (#6741)
4a498d7 
Fixes #6740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcantrill bcantrill bcantrill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OxQL predicates pushed into the DB ignore negation
2 participants
@bnaecker @bcantrill