(5/5) [nexus] Implement Affinity/Anti-Affinity Groups in external API #7447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 tasks
hawkw
approved these changes
Feb 6, 2025
| .. | ||
| } => { | ||
| Err(Error::invalid_request( | ||
| "when providing affinity_group as an ID project should not be specified", |
There was a problem hiding this comment.
nit: this reads like "(ID project) should not be specified", which is a bit nonsensical, so i think it should have a comma
Suggested change
| "when providing affinity_group as an ID project should not be specified", | |
| "when providing affinity_group as an ID, project should not be specified", |
There was a problem hiding this comment.
Yes, and unfortunately there are quite a few more: #7298
| .. | ||
| } => { | ||
| Err(Error::invalid_request( | ||
| "when providing anti_affinity_group as an ID project should not be specified", |
There was a problem hiding this comment.
Suggested change
| "when providing anti_affinity_group as an ID project should not be specified", | |
| "when providing anti_affinity_group as an ID, project should not be specified", |
| self.db_datastore | ||
| .affinity_group_update(opctx, &authz_group, updates.clone().into()) | ||
| .await | ||
| .map(|g| g.into()) |
There was a problem hiding this comment.
huh, can this not be
Suggested change
| .map(|g| g.into()) | |
| .map(Into::into) |
| updates.clone().into(), | ||
| ) | ||
| .await | ||
| .map(|g| g.into()) |
There was a problem hiding this comment.
similarly, could be
Suggested change
| .map(|g| g.into()) | |
| .map(Into::into) |
right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #7076
This PR is a partial implementation of RFD 522
It adds:
nexus/db-queries/src/db/datastore/sled.rs, within (4/5) [nexus] Consider Affinity/Anti-Affinity Groups during instance placement #7446Fixes #1705