[nexus] the support bundle task should execute diag commands concurrently #7461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
smklein
reviewed
Jan 31, 2025
Comment on lines
+651
to
+653
| while let Some(result) = diag_cmds.next().await { | ||
| result?; | ||
| } |
There was a problem hiding this comment.
Just to confirm, this will exit only if we fail to write the output of the command, not if the commands themselves fail, right? Just want to make sure that one failing command on a sled would not short-circuit everything else.
There was a problem hiding this comment.
Right, it's only going to fail if the tokio::write call fails on the support bundle file itself.
But thinking about this, should we instead log that we failed to write to file rather then potentially not getting through the entire array?
smklein
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some of the
sled-diagnosticscrates commands that were not yet being collected. Additionally we now have an array of commands that will be ran concurrently (currently limited to 10 at a time) that we can add to as more support commands become available.