update to daft 0.1.1 and oxnet 0.1.0 #7516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
ahl
approved these changes
Feb 11, 2025
Created using spr 1.3.6-beta.1
sunshowers
changed the title
sunshowers
deleted the
sunshowers/spr/wip-update-to-daft-011-and-oxnet-010
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release version of daft switches to somewhat lazier diffing, so we maintain
some nested maps. It would be interesting to see how eager diffing can be
brought back as an option in daft at some point, but this is ok for now.
Will land this after the r13 branch cut since this ended up being quite a big
effective change (especially maghemite).
This PR depends on: