Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generated files to match latest omicron version #226

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Update generated files to match latest omicron version #226

merged 2 commits into from
Dec 5, 2023

Conversation

charliepark
Copy link
Contributor

Updated OMICRON_VERSION and ran npm run gen-api over in console. Will submit that as a separate PR.

@charliepark charliepark requested a review from zephraph December 4, 2023 23:52
@charliepark charliepark mentioned this pull request Dec 4, 2023
Merged
@zephraph
Copy link
Contributor

zephraph commented Dec 4, 2023

Been a while since we've updated this! Looks good.

@zephraph
Copy link
Contributor

zephraph commented Dec 5, 2023

Weird situation with the update-api-spec step. It looks like it doesn't re-run when it triggers itself and because it's a required step that means it hangs when it's the last commit. I'll take another look at that later but no reason to block on it.

@zephraph zephraph merged commit 9406dfb into main Dec 5, 2023
2 checks passed
@zephraph zephraph deleted the charliepark/latest-omicron-version branch December 5, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zephraph zephraph zephraph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliepark @zephraph