Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

propolis-mock-server should expose more types #808

Merged
merged 4 commits into from
Nov 13, 2024
Merged

propolis-mock-server should expose more types #808

merged 4 commits into from
Nov 13, 2024

Conversation

davepacheco
Copy link
Contributor

@davepacheco davepacheco commented Nov 13, 2024 •
edited
Loading

@davepacheco davepacheco mentioned this pull request Nov 13, 2024
Merged
gjcolombo
gjcolombo approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@gjcolombo gjcolombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided it fixes things up in Omicron. Picking up this change there and running cargo nextest should verify that things are still working.

bin/mock-server/src/lib/lib.rs
Comment on lines +657 to +660
///
/// This function should be avoided in favor of `start()` because using this
/// function requires that the consumer and Propolis update Dropshot
/// dependencies in lockstep due to the sharing of various types.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just remove the pub instead? AFAIK (from a global GitHub search) the only user of this crate who calls this is simulated sled agent, which is presumably the consumer we want to switch to using start.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to do that but would prefer to do it in a separate PR to minimize the chance of breakage on the critical path here.

@davepacheco davepacheco merged commit aadc099 into master Nov 13, 2024
11 checks passed
@davepacheco davepacheco deleted the dap/mock-server-fix branch November 13, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjcolombo gjcolombo gjcolombo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davepacheco @gjcolombo